-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: port number_theory.legendre_symbol.norm_num to Tactic.NormNum.LegendreSymbol #5548
Conversation
Komyyy
commented
Jun 28, 2023
Mathbin -> Mathlib fix certain import statements move "by" to end of line add import to Mathlib.lean
Looks very nice! bors d+ |
✌️ Komyyy can now approve this pull request. To approve and merge a pull request, simply reply with |
bors r+ |
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
show (er : Q(ℤ)) × Q(jacobiSymNat 1 $eb = $er) from | ||
⟨mkRawIntLit 1, q(jacobiSymNat.one_left $eb)⟩ | ||
| a => | ||
match a % 0 with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks incorrect. I guess it should be a % 2
instead of a % 0
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, that's wrong, thank you.
I'll create the PR after porting Traversable
deriving handler.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.